Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt code to new Sockethub Client API #270

Merged
merged 7 commits into from
Jan 27, 2022

Conversation

silverbucket
Copy link
Member

@silverbucket silverbucket commented Jan 16, 2022

I started testing the sockethub refactor (sockethub/sockethub#596) with hyperchannel, and managed to fix a few things, however couldn't figure out how the join process was supposed to work after the connect (the connect works, just nothing is joined afterward).

Would be up to either pair with someone on finishing this, or if you just want to use this as an example branch and make a new PR that's fine with me too. The most important part to get started is to make sure you remove the <script> tags which include activity-streams.js as that's now a part of the sockethub-client.js

@raucao
Copy link
Member

raucao commented Jan 16, 2022

Nice!

Regarding joins, almost at the top of the changes in this branch, the code that handles completed joins is being removed entirely.

@silverbucket
Copy link
Member Author

Regarding joins, almost at the top of the changes in this branch, the code that handles completed joins is being removed entirely.

Yeah I saw that, however that's still for completed joins, I didn't see where joins were being requested after a connect.

@raucao raucao changed the title Example branch using new sockethub client (not fully working) Adapt code to new Sockethub Client API Jan 26, 2022
@raucao raucao requested a review from galfert January 26, 2022 21:17
@raucao raucao removed the request for review from galfert January 27, 2022 23:53
@raucao raucao merged commit e49a244 into master Jan 27, 2022
@raucao raucao deleted the example-refactored-sockethub-client branch January 27, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants