Send and handle leave messages for XMPP MUC #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating the ActivityStream object is not needed when leaving an IRC room.
raucao
reviewed
Aug 31, 2021
app/services/coms.js
Outdated
| @@ -173,7 +173,7 @@ export default class ComsService extends Service { | |||
| leaveChannel (channel) { | |||
| switch (channel.protocol) { | |||
| case 'XMPP': | |||
| // TODO implement | |||
| this.xmpp.leave(channel); | |||
There was a problem hiding this comment.
We can actually remove the protocol switch now, and do something like this:
this.getServiceForSockethubPlatform(channel.protocol)
.leave(channel);
raucao
reviewed
Aug 31, 2021
|
I've also added handling of the incoming "unavailable" presence updates that were fixed in sockethub/sockethub#565. Now everything should be working dandy. EDIT: Travis is green as well now. |
galfert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #239
During testing I noticed that Sockethub actually sends "online" presence updates for incoming "unavailable" stanzas. I've created an issue for that at sockethub/sockethub#564.
This PR also deletes the creation of the ActivityStream object when leaving an IRC room, because I confirmed that it's not needed.