Pending status for outgoing XMPP messages #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galfert
reviewed
Aug 30, 2021
app/controllers/base_channel.js
Outdated
| }); | ||
|
|
||
| if (this.model.protocol === 'XMPP') { |
There was a problem hiding this comment.
Why only for XMPP? Wouldn't it be the same process for IRC?
There was a problem hiding this comment.
Nope. You don't receive your own messages back from a channel in IRC.
Also fixes own messages being missing in channel history.
raucao
force-pushed
the
feature/xmpp_pending_messages
branch
from
471fc2e
to
cc00d2e
Compare
The dependency label is almost always orange, so let's change the sort order to make this look nicer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This marks outgoing messages as pending, and then confirms that they were sent when received back from the room. It also fixes the problem of one's own messages missing in the chat history that is sent by XMPP servers upon joining a channel.
Note: will probably fail with DMs (#242), because we would need message carbons for those. Hence the WIP, until DMs are merged.Fixed for DMs.P.S.: I think we'll want to have a timeout for showing messages as pending in the UI later on. Currently, there's a bit of a flash from switching the text color after a split second. And we can also add an actual text marker or other indicator, after a few seconds of it not having confirmed.