Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor spaces to accounts/channels for IRC #228

Merged
merged 7 commits into from
Aug 20, 2021
Merged

Refactor spaces to accounts/channels for IRC #228

merged 7 commits into from
Aug 20, 2021

Conversation

raucao
Copy link
Member

@raucao raucao commented Aug 20, 2021

  • Add component for setting up IRC accounts
  • Adapt IRC sockethub service and other relevant code for the new data model
  • Fix some small things

Note:

  • DMs are still disabled in the UI for now
  • There's some commented code to implement when Sockethub implements a connect command for IRC (currently being done automatically on channel joins).

@raucao raucao requested a review from galfert August 20, 2021 10:27
galfert
galfert approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@galfert galfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@raucao raucao merged commit f0b4ff3 into refactor/spaces_to_accounts Aug 20, 2021
@raucao raucao deleted the refactor/spaces_to_accounts_irc branch August 20, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galfert galfert galfert approved these changes

Assignees
No one assigned
Labels
kredits-2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raucao @galfert