Fix user settings in localStorage #220
Conversation
Switch from ember-local-storage to localForage (and thus IndexedDB by default). Contains a generic function which allows to extend a defaultValues object with more default data to be set for empty local storages. fixes #219
Leftover from hacking.
|
Totally confused. You didn't even remove |
app/services/local-data.js
Outdated
| Object.keys(defaultValues[storeName]).forEach(async key => { | ||
| const value = await store.getItem(key); | ||
| const defaultValue = defaultValues[storeName][key]; | ||
| if (isEmpty(value)) { await store.setItem(key, defaultValue); } |
There was a problem hiding this comment.
Be aware that forEach doesn't wait for any of the asynchronous functions before iterating over the next element. So the await for the store.setItem() call is superfluous.
There was a problem hiding this comment.
I have refactored the function to use for ... of. Thanks.
Values are set by the localData service when loading the app now.
|
CodeClimate is throwing a fit, but I disagree with it about the complexity of that function. |
| super.beforeModel(...arguments); | ||
| await this.localData.setDefaultValues(); |
| } | ||
|
|
||
| async setDefaultValues () { | ||
| for (const storeName of Object.keys(defaultValues)) { |
There was a problem hiding this comment.
What you can try is assign const defaultValuesKeys = Object.keys(defaultValues); outside the class...
There was a problem hiding this comment.
To make CodeClimate happy
raucao
force-pushed
the
bugfix/localstorage_user_settings
branch
from
b3df207
to
e5943dd
Compare
Switch from
ember-local-storagetolocalForage(and thus alsoIndexedDBby default).Contains a generic function which allows to extend a
defaultValuesobject in the service with more default data to be set for empty local storages.Testing this manually is possible by just seeing if loading the app from the root URL redirects to the last channel you had open or not (should not do on master, but should do with this fix).
fixes #219