Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Tailwind CSS with PurgeCSS and JIT compilation #218

Merged
merged 7 commits into from
Apr 14, 2021

Conversation

raucao
Copy link
Member

@raucao raucao commented Apr 13, 2021

Also removes Bourbon entirely, and switches Sass compilation from ember-cli-sass to PostCSS with plugins.

With this setup, we can now use Tailwind for new styles, as well as migrate existing ones to Tailwind classes and components over time.

We didn't actually use it much at all in the first place.
Also switches from ember-cli-sass to using only PostCSS for everything.
Just a little demo so we know JIT compilation etc. works.
@raucao raucao requested review from galfert and fsmanuel April 13, 2021 13:15
package.json Outdated
"@ember/optional-features": "^2.0.0",
"@ember/render-modifiers": "^1.0.2",
"@ember/test-helpers": "^2.2.5",
"@glimmer/component": "^1.0.1",
"@glimmer/tracking": "^1.0.4",
"autoprefixer": "^7.2.6",
"autoprefixer": "^10.2.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this library still needed? It looks like all references to it have been removed from ember-cli-build.js.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! Tailwind apparently comes with autoprefixer by default.

Co-authored-by: Garret Alfert <alfert@wevelop.de>
@raucao
Copy link
Member Author

raucao commented Apr 13, 2021

Removed the obsolete package...

Copy link
Contributor

@galfert galfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look ok and I couldn't find any problems during testing.

@raucao raucao merged commit 682ca68 into master Apr 14, 2021
@raucao raucao deleted the dev/introduce_tailwind-css branch April 14, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants