Update Ember and octanify all the things #202
Conversation
galfert
changed the title
|
Wow, this one is massive. 👀 |
|
Everything regarding chat itself seems to be working perfectly fine. However, I get an exception when trying to add a space from a preset: I remember that I tried upgrading the settings to Octane and then gave up, because I couldn't make it work. I'm not sure if we should spend much time on fixing the current settings, which are basically just a hack so that you can add more spaces at all. So maybe we should rather talk about how we want them to actually work and then spend time on a new implementation immediately. I definitely have a lot of thoughts on this that I haven't documented yet. @galfert Happy to jump on a call about it anytime. |
This fixes some errors that were missed in the Octane upgrade orgy.
|
The error itself was pretty easy to fix. I hadn't tried that part of the app myself yet, so I found a few other mistakes and fixed those as well. Now it should at least work the same as before. That doesn't prevent us from talking about your thoughts on better settings of course :) |
|
OK, great! |
|
Hooray! |
|
Missed one thing here still. ^^ |
Fixes #202 After the Octane upgrade, all observers were broken. Replacing them with render modifiers fixed the issues and also removed the last remaining deprecation warnings.
Closes #184
This updates Ember to the latest stable version (3.17) and updates the whole codebase to use the latest and greatest of Ember Octane (e.g. native JS classes, decorators, angle bracket components, ...)