Channel sidebar tabs/content #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The userlist doesn't need as much space as e.g. shared items or settings. This adds logic and styles for one wider size, and makes switching between the two widths work on both desktop and mobile.
We're moving the component to a route soon, so the outlet is perfectly fine there.
raucao
changed the title
|
Update: you can check this out in production right now: https://hyperchannel.kosmos.org But please be aware of #197 on small screens. |
|
I checked it on my phone and my laptop. LGTM! |
|
|
galfert
reviewed
Jan 30, 2020
| <button type="button" | ||
| {{action "menu" "channel" "toggle"}} | ||
| class={{if this.headerNavButtonUsersActive "active"}}> | ||
| <LinkTo @route="space.channel.index" @models={{array space channel}} {{action "menu" "channel" "show"}}> |
There was a problem hiding this comment.
Shouldn't this rather be [...] {{array this.space this.channel}} [...]?
There was a problem hiding this comment.
Yes, there are hundreds of Octane warnings still. Everyone is invited to help with the upgrade: #184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes channel sidebar content routable via channel subroutes, and adds header styles and dummy content. Also introduces wide sidebars for tabs with more content.
The sidebars work slightly different on desktop and mobile, as they're optimized for the available screen real estate.
Desktop
Mobile