Slide out channel sidebar on small screens #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just FYI: I have a follow-up PR ready on my machine, which makes the channel sidebar routable and adds support for wider sidebars with more content as well. Would be nice to merge this today, so I can do a PR against master with that. |
|
Please note that when testing this on mobile, there's also #197 showing up, which is not a problem caused by the code in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only includes the basic layout and functionality for now, i.e. only the userlist slides out, and the code has to be refactored a bit as soon as we actually add more sidebar views (like e.g. list of shared items, mentions, channel settings, and whatnot). On desktop, everything stays the same.
(Sorry about the jittering in the video gif. Not sure what happened there.)