Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

feat: show ERC-721 token ids #3330

Merged
merged 1 commit into from
Jan 21, 2022
Merged

feat: show ERC-721 token ids #3330

merged 1 commit into from
Jan 21, 2022

Conversation

iamacook
Copy link
Member

What it solves

Resolves #3241

How this PR fixes it

ERC-721 token names and amountWithSymbols are now appended with a (#tokenId).

How to test it

  1. Queue a ERC-721 token transfer.
  2. Observe the token id appended to the title and transaction info.

This should also be present on receipts as well.

Screenshots

Receipt

image

Send

image

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1718878451

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 32.199%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/safe/components/Transactions/TxList/utils.ts 1 3 33.33%
Totals Coverage Status
Change from base Build 1717681956: -0.002%
Covered Lines: 3113
Relevant Lines: 8606

💛 - Coveralls

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1718935675

Failed tests:

  • ❌ Safe Apps List Safe Apps List

@francovenica
Copy link
Contributor

Looks good to me
image
image

@iamacook iamacook merged commit 8eae6f1 into dev Jan 21, 2022
@iamacook iamacook deleted the erc721-tokenid branch January 21, 2022 06:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] [ui] ERC721 transfer queue does not show tokenId
4 participants