-
Notifications
You must be signed in to change notification settings - Fork 364
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Deployment links
|
E2E Tests Failed Failed tests:
|
} | ||
|
||
// FixMe: this way won't scale well | ||
if (isDeleteAllowance(txData.dataDecoded.method)) { | ||
return <DeleteSpendingLimitDetails data={txData.dataDecoded} /> | ||
console.log(txInfo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove console.log
const creator = useKnownAddress(txInfo.creator) | ||
const factory = useKnownAddress(txInfo.factory) | ||
const implementation = useKnownAddress(txInfo.implementation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Looks good with the modules I have to test. I don't have an "unknown module" address to test with. |
What it solves
Resolves #2990
How this PR fixes it
Interactions with modules in the transaction list now show their name and address in the transaction details. The name is shown in a priority of: address book name, name returned from backend,
"Unknown module"
.How to test it
Screenshots