Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plone4.3 compatability #1

Merged
merged 17 commits into from
Jun 5, 2020
Merged

Plone4.3 compatability #1

merged 17 commits into from
Jun 5, 2020

Conversation

djowett-ftw
Copy link

@djowett-ftw djowett-ftw commented Mar 31, 2020 •
edited
Loading

and add a setting to disable virus scanning

Daniel Jowett added 16 commits March 26, 2020 11:26
Start adding Plone 4.3 compatability
cc911a3
Unused post_handlers removed as Plone 4.3's GenericSetup version does…
67b8be4 
… not support them
TEMP: scan in development mode
0603ed8
Switch to Plone 4.3 for now. Explicit index
2afd433
Remove code-analysis
c7f675f
Remove robot testing to get buildout working
016b38a 
    It's not being used
Fix tests with plone.protect upgrade
0b0cbb3
Add a setting to disable virus scanning (Defaults to true)
1ebeb50 
    Use this to solve the KeyError which occurs when product not installed
Re-add code-analysis
8e14232 
    with fix to buildout

This reverts commit c7f675f.
Add test setups for Plone 4.3 and 5.0
2ecd3b8
Remove traces of robot tests - we are not using these
1a6b0d2
Test disabling virus scans
8b7b473
Fix Plone 5.0 tests
d922ffe
Refactor testing setup to make way for Archetypes testing
6a66db9
Revert "TEMP: scan in development mode"
b42b9d2 
This reverts commit 0603ed8.
Changelog
2446359
@djowett-ftw djowett-ftw requested a review from buchi March 31, 2020 15:56
@djowett-ftw
Copy link
Author

Part of solution to 4teamwork/ftw.file#107

buchi
buchi approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@buchi buchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

I would probably keep the buildout.cfg file there instead of renaming it to development.cfg.
As it's not our package, it doesn't have to meet our standards.

@djowett-ftw djowett-ftw merged commit 577be70 into 2.x Jun 5, 2020
@djowett-ftw djowett-ftw deleted the dj_2.x_plone4.3_compatability branch June 5, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buchi buchi buchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djowett-ftw @buchi