Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new endpoint - list repository events #811

Merged
merged 9 commits into from
Aug 11, 2022

Conversation

josevi96
Copy link
Contributor

@josevi96 josevi96 commented Aug 10, 2022

New endpoint to list the events of a particular repository with listPublicRepositoryEvents using the owner and the repo's name.
Github docs:
https://docs.github.com/en/rest/activity/events#list-repository-events

@josevi96 josevi96 force-pushed the add_list_public_repository_events_endpoint branch from c58ac40 to 883191d Compare August 10, 2022 13:07
@josevi96 josevi96 marked this pull request as ready for review August 10, 2022 14:24
@josevi96
Copy link
Contributor Author

josevi96 commented Aug 10, 2022

Hi folks!, I was thinking about merging the PublicRepositoryEvent and the PublicOrganizationEvent as they are almost the same.
They are different entities in the github API so I decided to separate them, what do you think?

@josevi96 josevi96 added enhancement New feature or request documentation Improvements or additions to documentation labels Aug 10, 2022
@@ -265,6 +265,25 @@ object Decoders {
)
)

implicit val decodePublicRepositoryEvent: Decoder[PublicRepositoryEvent] =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PublicRepositoryEvent model looks similar to PublicOrganizationEvent. Can you please check the API and see if we can reuse the model?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they share the same schema, we can merge both models into the same one

Copy link
Contributor

@necosta necosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great contribution 💪

@josevi96 josevi96 merged commit e7c0793 into main Aug 11, 2022
@josevi96 josevi96 deleted the add_list_public_repository_events_endpoint branch August 11, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants