Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

Fix command injection vulnerability #1

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Fix command injection vulnerability #1

merged 1 commit into from
Apr 17, 2020

Conversation

69
Copy link

@69 69 commented Apr 3, 2020

No description provided.

Copy link

@toufik-airane toufik-airane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a testing case to prove the successful mitigation?
Thank you.

@69
Copy link
Author

69 commented Apr 10, 2020

The original POC no longer works:

// poc.js
const Repo = require("gry");
var myRepo = new Repo(".");
myRepo.pull('test; touch HACKED; #', function(){console.log('Finished!')})

and instead throws an error:

Error: fatal: 'test;' does not appear to be a git repository
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

@JamieSlome
Copy link

We will re-review this pull request next week - thanks for the contribution! 🍰

@toufik-airane
Copy link

Thank you. LGTM. 👍

@huntr-helper
Copy link
Member

Congratulations @69 - your fix has been selected! 🎉

Thanks for being part of the community & helping secure the world's open source code.
If you have any questions, please respond in the comments section. Your bounty is on its way - keep hunting!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants