Fix the custom module example #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for reporting this. Will try to get it merged today. |
|
Looks like this reveals some issues in how to properly solve module inheritance and sharing methods. Opened #308 to keep digging. |
|
@ErwinSteffens I made a PR that tries to describe module inheritance and adds an example - #362 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to extend the default apicast module by using this example, but we ran into some issues. I think this merge request should fix the example, but I'am not much of an lua expert.
The
module.luafile loads theapicastor the overriden module, but calls thenew()method when it is available. When the new method is not overridden it just returns theapicastmodule and not the module override.The new code works for us.