Policy: IPCheck validate that port is not used. #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fix the issue when port is added into the forwarder-for header and IPCheck will not match correctly. Fix THREESCALE-5258 Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
|
Looks great to me! |
davidor
reviewed
May 26, 2020
| -- host | ||
| -- `:` split is not valid in case that it's IPv6 notation. | ||
| local host = re.split(forwarded_for, ',', 'oj')[1] | ||
| local uri = resty_url.parse("my://".. host) |
There was a problem hiding this comment.
if no scheme, the resty_url will fail, so it's the safest way to detect if IP/PORT is in there, also with IPv4/IPv6 combitation.
There was a problem hiding this comment.
👍
It'd be useful to add a comment that clarifies that.
There was a problem hiding this comment.
It's already in there :\
davidor
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fix the issue when port is added into the forwarder-for
header and IPCheck will not match correctly.
Fix THREESCALE-5258
Signed-off-by: Eloy Coto eloy.coto@acalustra.com