http_proxy: set Host domain correctly #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloycoto
force-pushed
the
HTTP_proxy_HOST_HEADER
branch
3 times, most recently
from
91304bf
to
8bfad8c
Compare
If http_proxy is set the host header is always rewritten to the IP. With this change the http_proxy will be set to the DNS name to avoid issues with virtual host in the endpoints. Fix THREESCALE-4178 Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
eloycoto
force-pushed
the
HTTP_proxy_HOST_HEADER
branch
from
8bfad8c
to
c31cee0
Compare
eloycoto
changed the title
davidor
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If http_proxy is set the host header is always rewritten to the IP. With
this change the http_proxy will be set to the DNS name to avoid issues
with virtual host in the endpoints.
Signed-off-by: Eloy Coto eloy.coto@gmail.com