Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] - Fixes Caching and CodeQL Workflows #684

Closed
wants to merge 2 commits into from

Conversation

adithyaakrishna
Copy link
Contributor

@adithyaakrishna adithyaakrishna commented Jun 12, 2023

Description:

  • PR Adds Caching of Workflows
  • PR Fixes CodeQL Workflows

Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #684 (21fe21f) into master (80fc603) will not change coverage.
The diff coverage is n/a.

❗ Current head 21fe21f differs from pull request most recent head 1e17bb5. Consider uploading reports for the commit 1e17bb5 to get more accurate results

@@           Coverage Diff           @@
##           master     #684   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files         141      141           
  Lines       11450    11450           
  Branches     2112     2112           
=======================================
  Hits         9505     9505           
  Misses       1613     1613           
  Partials      332      332           

@adithyaakrishna
Copy link
Contributor Author

@dkoes This PR is Ready for Review as well :)

@dkoes
Copy link
Contributor

dkoes commented Jun 13, 2023

Still doesn't work. You need to test the CI with and without the cache (the first time it runs it will work because there is nothing in the cache). At best it saves 40 seconds.

@adithyaakrishna
Copy link
Contributor Author

This is a bit strange, https://github.com/adithyaakrishna/3Dmol.js/actions/runs/5252761546/jobs/9489220710 - Test passes on the fork but not on PR :/

@adithyaakrishna
Copy link
Contributor Author

Closing this and will open a new PR for the same :)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants