Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dev dependency clean-jsdoc-them wrongly marked as dependency #724

Closed
NicolasCARPi opened this issue Oct 1, 2023 · 2 comments
Closed
Labels

Comments

@NicolasCARPi
Copy link
Contributor

Hello 👋

Describe the bug

When updating 3Dmol.js from 2.0.3 to 2.0.5 I saw this warning:

2023-10-01-212708_733x48_scrot

and wondered why 3dmol.js would need jsdoc. It seems this commit: df952eb by @adithyaakrishna introduced the theme as a dependency instead of a dev dependency, with its friend jsdoc which is adequately listed in devDependencies.

As you know, this is a major issue for downstream projects depending on the 3dmol.js package, which then inherit a bunch of dependencies for the wrong reasons (17 new npm packages in my case).

Of course, when I say major issue, I mean it's a blocker for us but there are worse things in life, and this is definitely not a "drop everything and fix it" situation, but surely something that needs to be patched.

To Reproduce
Upgrade 3dmol.js to its latest version.

Expected behavior
All dev dependencies are declared as such.

Screenshots
2023-10-01-214015_722x134_scrot

Additional context
October's debut,
Paris basks in fiery heat,
Sunday's warmth, a treat.

mochi-peach

dkoes added a commit that referenced this issue Oct 1, 2023
theme should indeed be a dev dependency
@adithyaakrishna
Copy link
Contributor

@NicolasCARPi Will send a fix for it, thanks for pointing it out :)

@adithyaakrishna
Copy link
Contributor

adithyaakrishna commented Oct 2, 2023

Oops! I missed, I guess @dkoes already sent one 😅

NicolasCARPi added a commit to elabftw/elabftw that referenced this issue Oct 9, 2023
@dkoes dkoes closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants