You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When updating 3Dmol.js from 2.0.3 to 2.0.5 I saw this warning:
and wondered why 3dmol.js would need jsdoc. It seems this commit: df952eb by @adithyaakrishna introduced the theme as a dependency instead of a dev dependency, with its friend jsdoc which is adequately listed in devDependencies.
As you know, this is a major issue for downstream projects depending on the 3dmol.js package, which then inherit a bunch of dependencies for the wrong reasons (17 new npm packages in my case).
Of course, when I say major issue, I mean it's a blocker for us but there are worse things in life, and this is definitely not a "drop everything and fix it" situation, but surely something that needs to be patched.
To Reproduce
Upgrade 3dmol.js to its latest version.
Expected behavior
All dev dependencies are declared as such.
Screenshots
Additional context
October's debut,
Paris basks in fiery heat,
Sunday's warmth, a treat.
The text was updated successfully, but these errors were encountered:
Hello 👋
Describe the bug
When updating 3Dmol.js from 2.0.3 to 2.0.5 I saw this warning:
and wondered why 3dmol.js would need jsdoc. It seems this commit: df952eb by @adithyaakrishna introduced the theme as a dependency instead of a dev dependency, with its friend
jsdoc
which is adequately listed in devDependencies.As you know, this is a major issue for downstream projects depending on the 3dmol.js package, which then inherit a bunch of dependencies for the wrong reasons (17 new npm packages in my case).
Of course, when I say major issue, I mean it's a blocker for us but there are worse things in life, and this is definitely not a "drop everything and fix it" situation, but surely something that needs to be patched.
To Reproduce
Upgrade 3dmol.js to its latest version.
Expected behavior
All dev dependencies are declared as such.
Screenshots
Additional context
October's debut,
Paris basks in fiery heat,
Sunday's warmth, a treat.
The text was updated successfully, but these errors were encountered: