feat: use cookiejar synchronous functions by default #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: if you want to use async cookiejar store, pass cookies.async_UNSTABLE to true.
3846masa
changed the title
3846masa
added a commit
that referenced
this pull request
May 7, 2022
BREAKING CHANGE: The property name for passing cookiejar to agent has been changed. BREAKING CHANGE: Changed to use cookiejar synchronous functions by default. If you use an asynchronous cookiejar store, pass cookies.async_UNSTABLE to true.
3846masa
added a commit
that referenced
this pull request
May 7, 2022
BREAKING CHANGE: The property name for passing cookiejar to agent has been changed. BREAKING CHANGE: Changed to use cookiejar synchronous functions by default. If you use an asynchronous cookiejar store, pass cookies.async_UNSTABLE to true.
3846masa
added a commit
that referenced
this pull request
May 7, 2022
BREAKING CHANGE: The property name for passing cookiejar to agent has been changed. BREAKING CHANGE: Changed to use cookiejar synchronous functions by default. If you use an asynchronous cookiejar store, pass cookies.async_UNSTABLE to true.
3846masa
added a commit
that referenced
this pull request
May 7, 2022
BREAKING CHANGE: The property name for passing cookiejar to agent has been changed. BREAKING CHANGE: Changed to use cookiejar synchronous functions by default. If you use an asynchronous cookiejar store, set cookies.async_UNSTABLE to true.
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2022
# [3.0.0](v2.1.2...v3.0.0) (2022-05-07) ### Features * change import path for node:http ([#105](#105)) ([6260bdc](6260bdc)) * update README and add MIGRATION GUIDES ([#110](#110)) ([cb03a9f](cb03a9f)) * use cookiejar synchronous functions by default ([#107](#107)) ([2bf68bb](2bf68bb)) ### BREAKING CHANGES * see MIGRATION.md for more details. * The property name for passing cookiejar to agent has been changed. * Changed to use cookiejar synchronous functions by default. If you use an asynchronous cookiejar store, set cookies.async_UNSTABLE to true. * you should import `'http-cookie-agent/node:http'` instead of `'http-cookie-agent'`.
3846masa
pushed a commit
that referenced
this pull request
May 8, 2022
# [3.0.0](v2.1.2...v3.0.0) (2022-05-07) ### Features * change import path for node:http ([#105](#105)) ([6260bdc](6260bdc)) * update README and add MIGRATION GUIDES ([#110](#110)) ([cb03a9f](cb03a9f)) * use cookiejar synchronous functions by default ([#107](#107)) ([2bf68bb](2bf68bb)) ### BREAKING CHANGES * see MIGRATION.md for more details. * The property name for passing cookiejar to agent has been changed. * Changed to use cookiejar synchronous functions by default. If you use an asynchronous cookiejar store, set cookies.async_UNSTABLE to true. * you should import `'http-cookie-agent/node:http'` instead of `'http-cookie-agent'`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The property name for passing cookiejar to agent has been changed.
BREAKING CHANGE: Changed to use cookiejar synchronous functions by default. If you use an asynchronous cookiejar store, pass
cookies.async_UNSTABLEto true.