Improve Dockerfile #317
Open
Improve Dockerfile #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use VIRTUAL_ENV into Dockerfile instead of user system path Improve local image size optimization
Remove `k8s` and add `terraform` directory from dockerignore
trottomv
requested review from
pauloxnet,
Arussil,
filippo-20tab,
niccolomineo and
Mitchina
|
I would do without depending on customizing the $PATH in the IDE, as this PR is currently hinting at. Else, we would make the development environment unreasonably stiffer for all non Talos-based projects. |
pauloxnet
previously approved these changes
Aug 26, 2024
trottomv
force-pushed
the
feature/dockerfile-venv
branch
from
8f84895
to
29d0782
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k8sand addterraformdirectory from .dockerignore