Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TG-1015 Replace cookiecut project's black with ruff format #290

Merged
merged 7 commits into from
Jan 11, 2024
Merged

TG-1015 Replace cookiecut project's black with ruff format #290

merged 7 commits into from
Jan 11, 2024

Conversation

niccolomineo
Copy link
Member

@niccolomineo niccolomineo commented Jan 3, 2024 •
edited
Loading

No description provided.

@niccolomineo niccolomineo self-assigned this Jan 3, 2024
@niccolomineo niccolomineo force-pushed the feature/1015-ruff-format branch 2 times, most recently from 31e0193 to 8c95a08 Compare January 4, 2024 18:41
@niccolomineo
Copy link
Member Author

This PR is currently blocked due to the following pyproject rules making ruff format error out:

extend-exclude = [
    "__pycache__",
    ".vscode*",
]

Confirmed to be a bug on their side.

@niccolomineo niccolomineo changed the title TG-1015 Replace black with ruff format TG-1015 Replace the project's black with ruff format Jan 11, 2024
@niccolomineo
Copy link
Member Author

We agreed on bringing this change to the cookiecut project only, leaving out the bootstrap, until the issue is fixed on the Astral's side.

@niccolomineo niccolomineo changed the title TG-1015 Replace the project's black with ruff format TG-1015 Replace cookiecut project's black with ruff format Jan 11, 2024
@niccolomineo niccolomineo marked this pull request as ready for review January 11, 2024 09:01
@pauloxnet pauloxnet merged commit 96a5194 into main Jan 11, 2024
1 check passed
@trottomv trottomv deleted the feature/1015-ruff-format branch January 11, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauloxnet pauloxnet pauloxnet approved these changes

@trottomv trottomv trottomv approved these changes

Assignees

@niccolomineo niccolomineo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niccolomineo @pauloxnet @trottomv