More Fixes for 1.0.0-rc2 Release #44

ohsh6o · 2021-01-01T20:21:15Z

This time, these changes will collect the last remaining bits and pieces for the move to 1.0.0-rc1.

Closes #39.

Since 1.0.0-rc1 introduced some breaking changes, we need to check for this now. The new upgraded example SSP does not have that field edited since I believe it was manually created and/or manually edited after it was run through the usnistgov/OSCAL M3->RC1 upconverter, this seems to have been missed.

Put them in the right locations in the report instead of repeating them ad nauseam.

This is annoying and distoring module updates.

We will need to make way for reading values from upstream OSCAL Metaschema files.

It can only fire once, which is why tests were breaking.

github-actions · 2021-01-18T14:55:03Z

Unit Test Results

  1 files ±0   2 suites ±0 0s ⏱️ ±0s
  0 tests ±0   0 ✔️ ±0 0 💤 ±0 0 ✖️ ±0
46 runs +3 46 ✔️ +3 0 💤 ±0 0 ✖️ ±0

results for commit 42c5cec ± comparison against base commit 6524f06

During the rebase and what looked like the last commit, this somehow got lost not once, but twice!

github-actions · 2021-01-18T15:01:51Z

Unit Test Results

  1 files ±0   2 suites ±0 0s ⏱️ ±0s
  0 tests ±0   0 ✔️ ±0 0 💤 ±0 0 ✖️ ±0
46 runs +3 46 ✔️ +3 0 💤 ±0 0 ✖️ ±0

results for commit 68b7324 ± comparison against base commit 6524f06

Will add tests then use it for context filter.

github-actions · 2021-01-18T22:42:15Z

Unit Test Results

  1 files ±0   2 suites ±0 0s ⏱️ ±0s
  0 tests ±0   0 ✔️ ±0 0 💤 ±0 0 ✖️ ±0
46 runs +3 46 ✔️ +3 0 💤 ±0 0 ✖️ ±0

results for commit 57fdca1 ± comparison against base commit 6524f06

@ns

Passing in the @ns attribute as just a string won't work.

github-actions · 2021-01-20T14:09:58Z

Unit Test Results

  1 files ±0   2 suites ±0 0s ⏱️ ±0s
  0 tests ±0   0 ✔️ ±0 0 💤 ±0 0 ✖️ ±0
46 runs +3 46 ✔️ +3 0 💤 ±0 0 ✖️ ±0

results for commit 0643030 ± comparison against base commit 6524f06

github-actions · 2021-01-20T14:49:33Z

Unit Test Results

  1 files ±0   2 suites ±0 0s ⏱️ ±0s
  0 tests ±0   0 ✔️ ±0 0 💤 ±0 0 ✖️ ±0
48 runs +5 48 ✔️ +5 0 💤 ±0 0 ✖️ ±0

results for commit 2a5346f ± comparison against base commit 6524f06

github-actions · 2021-01-20T15:16:11Z

Unit Test Results

  1 files ±0   2 suites ±0 0s ⏱️ ±0s
  0 tests ±0   0 ✔️ ±0 0 💤 ±0 0 ✖️ ±0
52 runs +9 52 ✔️ +9 0 💤 ±0 0 ✖️ ±0

results for commit 7196ee3 ± comparison against base commit 6524f06

github-actions · 2021-01-20T19:14:42Z

Unit Test Results

  1 files ±0   2 suites ±0 0s ⏱️ ±0s
  0 tests ±0   0 ✔️ ±0 0 💤 ±0 0 ✖️ ±0
52 runs +9 52 ✔️ +9 0 💤 ±0 0 ✖️ ±0

results for commit 52a2a4b ± comparison against base commit 6524f06

github-actions · 2021-01-20T20:16:59Z

Unit Test Results

  1 files ±0   2 suites ±0 0s ⏱️ ±0s
  0 tests ±0   0 ✔️ ±0 0 💤 ±0 0 ✖️ ±0
52 runs +9 52 ✔️ +9 0 💤 ±0 0 ✖️ ±0

results for commit 465bcdb ± comparison against base commit 6524f06

…fixups

github-actions · 2021-05-05T18:10:14Z

XSpec Test Results

  1 files ±0   2 suites ±0 0s ⏱️ ±0s
52 tests +9 52 ✔️ +9 0 💤 ±0 0 ❌ ±0

Results for commit 0c3de86. ± Comparison against base commit 28978ae.

This pull request removes 2 and adds 11 tests. Note that renamed tests count towards both.

with lv:registry when a valid filesystem path is provided the function will return a non-empty collection of information types, threats, and values
with lv:registry when an invalid filesystem path is provided the function will return an empty collection of information types, threats, and values

when the document metadata should have an OSCAL version number and it is defined with an unsupported OSCAL version it is invalid. assert unsupported-oscal-version fatal
when the document metadata should have an OSCAL version number and it is defined with the supported OSCAL version it is valid. not assert unsupported-oscal-version
when the document metadata should have an OSCAL version number and it is not defined it is invalid. assert unsupported-oscal-version fatal
with lv:extension-registry when a valid filesystem path is provided the function will return a non-empty collection of information types, threats, and values
with lv:extension-registry when an invalid filesystem path is provided the function will return an empty collection of information types, threats, and values
with lv:has-core-ns when a node with an explicit @ns attribute is provided that does not match the OSCAL default the function returns false
with lv:has-core-ns when a node with an explicit @ns attribute is provided that matches the OSCAL default the function returns true
with lv:has-core-ns when a node with no explicit @ns attribute is provided the function returns true
with lv:has-extension-ns when a node with an explicit @ns attribute does match the extension registry in the SSP the function returns true
with lv:has-extension-ns when a node with an explicit @ns attribute does not match the extension registry in the SSP the function returns false
…

This comment has been minimized.

Sign in to view

ohsh6o force-pushed the issue-39-oscal-rc1-fixups branch from ea0b261 to f6e9842 Compare January 12, 2021 17:02

This comment has been minimized.

Sign in to view

ohsh6o mentioned this pull request Jan 14, 2021

Tasks/issue 32b #49

Merged

aj-stein-gsa added 11 commits January 18, 2021 09:10

Add version check.

dc66045

Add tests and normalize //oscal-version/text() to lower case.

dd324b3

Properly hoist response point corrections.

318e0a2

Put them in the right locations in the report instead of repeating them ad nauseam.

Try and update .gitmodules to disable dirty checks.

88fdfe6

This is annoying and distoring module updates.

Nope, ignore .gitmodules dirty, not untracked.

ec922f5

Update OSCAL module to 1.0.0-rc1 for SSP updates.

f7bc59b

Relocate current registry to extension registry.

fbe9846

We will need to make way for reading values from upstream OSCAL Metaschema files.

More touchups and forgot to add test fixes.

902c7e6

Remove old debugging code I missed.

027a86f

Clean up /o:metadata rule context.

42c5cec

It can only fire once, which is why tests were breaking.

ohsh6o force-pushed the issue-39-oscal-rc1-fixups branch from 180e2da to 42c5cec Compare January 18, 2021 14:53

Re-revert from master going back to older OSCAL.

68b7324

During the rebase and what looked like the last commit, this somehow got lost not once, but twice!

Add namespace testing functions.

57fdca1

Will add tests then use it for context filter.

Rename functions and do not pass in only attr.

0643030

Passing in the @ns attribute as just a string won't work.

Add some tests for new helper functions.

2a5346f

More complete test suite on two new fns.

7196ee3

Woops rearrange tests correctly.

52a2a4b

I guess I can simplify ns check logic.

465bcdb

ohsh6o changed the title ~~More Fixes for 1.0.0-rc1 Release~~ More Fixes for 1.0.0-rc2 Release Apr 8, 2021

Merge remote-tracking branch 'origin/master' into issue-39-oscal-rc1-…

0c3de86

…fixups

ohsh6o closed this May 11, 2021

ohsh6o deleted the issue-39-oscal-rc1-fixups branch May 11, 2021 04:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More Fixes for 1.0.0-rc2 Release #44

More Fixes for 1.0.0-rc2 Release #44

ohsh6o commented Jan 1, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 18, 2021

github-actions bot commented Jan 18, 2021

github-actions bot commented Jan 18, 2021

github-actions bot commented Jan 20, 2021

github-actions bot commented Jan 20, 2021

github-actions bot commented Jan 20, 2021

github-actions bot commented Jan 20, 2021

github-actions bot commented Jan 20, 2021

github-actions bot commented May 5, 2021

More Fixes for 1.0.0-rc2 Release #44

More Fixes for 1.0.0-rc2 Release #44

Conversation

ohsh6o commented Jan 1, 2021 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 18, 2021

Unit Test Results

github-actions bot commented Jan 18, 2021

Unit Test Results

github-actions bot commented Jan 18, 2021

Unit Test Results

github-actions bot commented Jan 20, 2021

Unit Test Results

github-actions bot commented Jan 20, 2021

Unit Test Results

github-actions bot commented Jan 20, 2021

Unit Test Results

github-actions bot commented Jan 20, 2021

Unit Test Results

github-actions bot commented Jan 20, 2021

Unit Test Results

github-actions bot commented May 5, 2021

XSpec Test Results

ohsh6o commented Jan 1, 2021 •

edited

Loading