Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contact form #390

Closed
GUI opened this issue Jun 15, 2017 · 1 comment
Closed

Fix contact form #390

GUI opened this issue Jun 15, 2017 · 1 comment

Comments

@GUI
Copy link
Member

GUI commented Jun 15, 2017

Looks like our contact form at https://api.data.gov/contact/ became broken after the larger API Umbrella v0.14 upgrade: #382

I think the issue is just some differences in CSRF handling on this API endpoint due to the Rails 4 upgrade behind the scenes.

GUI added a commit to NREL/api-umbrella that referenced this issue Jun 16, 2017
There were a couple issues with the contact form on the example static
site that was preventing it from sending messages:

- In the example static site, the form was missing a couple of new
  fields that the API now requires (a subject and the name of the API):
  NREL/api-umbrella-static-site@c02b886
- Since the Rails 4 upgrade in API Umbrella v0.14, the serialization of
  the e-mail messages into delayed job was broken (since ActiveJob won't
  serialize arbitrary models). This is fixed by serializing the data as
  a plain hash instead.

This adds missing tests for this whole contact API, and also adds
integration tests to make sure the example static site form works in the
browser.

18F/api.data.gov#390
@GUI
Copy link
Member Author

GUI commented Jun 16, 2017

Should be fixed. It was actually related to serialization changes in how ActiveJob/delayed_job handles things in Rails 4 (see NREL/api-umbrella@96862e0).

@GUI GUI closed this as completed Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant