Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Guide for working with Meta values in the Query Loop Block #43

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

xavortm
Copy link
Member

@xavortm xavortm commented Apr 29, 2022

Add a new page to describe how we can output custom information in the query loop.

Still work in progress

@xavortm xavortm added the Guide label Apr 29, 2022
@xavortm xavortm self-assigned this Apr 29, 2022
@fabiankaegy fabiankaegy changed the title Add initial files for docs page Add Guide for working with Meta values in the Query Loop Block Apr 29, 2022
@xavortm
Copy link
Member Author

xavortm commented Jun 21, 2022

Hey @fabiankaegy I just added some more information as requested about pulling and updating post meta. There are two different contexts in which we use Meta, so I wrote the first part for meta like "post data" or similar that we show under the titles on post cards. And the second part is about stored post meta from the database and updating it. Ready for review I think ^^

@xavortm xavortm requested a review from fabiankaegy June 21, 2022 08:50
@fabiankaegy
Copy link
Member

@xavortm This is great :)

The only thing I would love to add at the bottom of the guide is to be very clear about the fact that you can combine the useEntryProp hook to read meta values within a block in the query loop using the postId context :)

@xavortm
Copy link
Member Author

xavortm commented Jul 11, 2022

Hey @fabiankaegy , I added some more content to the post, I think it is ready for review. Note that I wasn't very certain about some points and I spend most of the time researching and trying to run a demo to test it

@fabiankaegy
Copy link
Member

Hey @xavortm 👋

I really like the changes & additions you've made. The illustration you've added is a gem as always 🤩

The comments I've made in my earlier review here: #43 (comment) still apply. I'd love to see the connection between the two concepts you are explaining here by using the meta value inside the query loop :)

@xavortm This is great :)

The only thing I would love to add at the bottom of the guide is to be very clear about the fact that you can combine the useEntryProp hook to read meta values within a block in the query loop using the postId context :)

merge latest changes into branch
@vercel
Copy link

vercel bot commented Jul 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
10up-gutenberg-best-practices ✅ Ready (Inspect) Visit Preview Jul 12, 2022 at 6:51AM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Guide for building atomic blocks for post meta values to be used within the Query Loop
2 participants