Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage search has incorrect width #151

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AshutoshNanaware
Copy link

Description of the Change

Homepage search has incorrect width:
Fixed the width of dropdown to be same as search bar.

Closing #

Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
10up-gutenberg-best-practices ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 5:45pm

@fabiankaegy
Copy link
Member

Hey @AshutoshNanaware 👋

Thank you for working on this :)

The width is now looking great, however it is a little jarring that the height of the cyan backdrop element now also changes with the search element. Before this change the overlay actually was floating on top of the element.
CleanShot 2023-12-11 at 22 48 44@2x

Ideally, that behavior would be retained. Just with the new width.

@AshutoshNanaware
Copy link
Author

Hello @fabiankaegy ,

I've fixed the list element style issue. My apologies for not testing with some elements in the dropdown initially.

New dropdown:
image

Current Dropdown UI:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants