Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache the Api response #380

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Cache the Api response #380

merged 5 commits into from
Mar 11, 2024

Conversation

burhandodhy
Copy link
Collaborator

Description of the Change

This PR cache the API response even when the API returns the error

Closes #367

How to test the Change

Changelog Entry

Changed - Cache the API response and display a message from where use can retry the API again.

Credits

Props @burhandodhy @jonnynews

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

# This is the 1st commit message:

Cache the Accounts api response

# This is the commit message #2:

Minor change

# This is the commit message #3:

Fix linting issues

# This is the commit message #4:

Fix linting issues

# This is the commit message #5:

Adjust feedback

# This is the commit message #6:

Fix linting

# This is the commit message #7:

Change variable name

# This is the commit message #8:

Change variable name
@burhandodhy burhandodhy merged commit edcab2c into develop Mar 11, 2024
13 checks passed
@burhandodhy burhandodhy deleted the fix/367 branch March 11, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing experiences REST API request
2 participants