Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix playlist preview in the editor #216

Merged
merged 4 commits into from
Aug 3, 2021
Merged

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Aug 2, 2021

Description of the Change

When the user adds a playlist in the editor, the playlist is rendered using a video player. This change fixes the playlist preview to use a playlist player.

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

  1. Add the Brightcove block and add a playlist
  2. Check if the player utilized is a playlist player

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

Fixed playlist preview in the editor

@Rahmon Rahmon added this to the 2.2.0 milestone Aug 2, 2021
@oscarssanchez oscarssanchez self-requested a review August 3, 2021 02:29
Copy link
Contributor

@oscarssanchez oscarssanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @Rahmon

@Rahmon Rahmon merged commit 47e412c into develop Aug 3, 2021
@Rahmon Rahmon deleted the fix/playlist-preview-in-editor branch August 3, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants