Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upgrade php and phpunit #34

Merged
merged 17 commits into from
Nov 23, 2023
Merged

Conversation

dsawardekar
Copy link
Collaborator

Description of the Change

  • Upgrade PHPUnit to 9.x
  • Fixes failing tests on PHPUnit 9.x
  • Fixes PHP warnings when running on PHP 8.2

Closes #33

How to test the Change

  • With the Block Catalog plugin active, on PHP 8.2+
  • Run any Block Catalog or WP CLI command like, wp block-catalog index
  • You should not see any PHP Warnings

Changelog Entry

Fixed - PHP 8.2 deprecation warnings
Added - PHPUnit 9.x support

Credits

Props @dsawardekar

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dsawardekar dsawardekar requested a review from a team as a code owner November 23, 2023 10:41
@dsawardekar dsawardekar requested review from peterwilsoncc and removed request for a team November 23, 2023 10:41
Copy link
Contributor

@ravinderk ravinderk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsawardekar, I left a few comments. Let me know if you have any questions.

includes/classes/CatalogBuilder.php Outdated Show resolved Hide resolved
includes/classes/CatalogBuilder.php Outdated Show resolved Hide resolved
@dsawardekar
Copy link
Collaborator Author

@ravinderk There were a few linter warnings. I've added those opts back with phpcs to ignore the warnings.

@ravinderk ravinderk merged commit 61393ac into develop Nov 23, 2023
5 checks passed
@ravinderk ravinderk deleted the feature/upgrade-php-and-phpunit branch November 23, 2023 15:22
@jeffpaul jeffpaul modified the milestone: 1.6.0 Dec 1, 2023
@jeffpaul jeffpaul added this to the 1.5.3 milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP Warnings due to missing defaults in CatalogCommand
4 participants