Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(1149): Added Pouchdb operations #5

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Feat(1149): Added Pouchdb operations #5

merged 1 commit into from
Jul 27, 2021

Conversation

akhilmhdh
Copy link
Collaborator

@akhilmhdh akhilmhdh commented Jul 15, 2021 •
edited by ghanlohar
Loading

Closes

Closes 1149

Explain the feature/fix

  1. Added Pouchdb integration
  2. Implemented Pouchdb operations for handling necessary operations of Ideas, Votes, Comments, Likes and other uitility operation
  3. Added onChange sync for live changes

Does this PR introduce a breaking change

Yes

Screenshots

NA

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
  • Does the change have appropriate unit tests?
  • Did tests pass?
  • Did you update or add any necessary documentation (README.md, WHY.md, etc.)?
  • Was this feature demo'd and the design review approved?

@akhilmhdh akhilmhdh added the enhancement New feature or request label Jul 15, 2021
@akhilmhdh akhilmhdh self-assigned this Jul 15, 2021
@akhilmhdh akhilmhdh changed the title Feat(1149): Added u Feat(1149): Added Pouchdb operations Jul 15, 2021
deshmukhmayur
deshmukhmayur requested changes Jul 22, 2021
View reviewed changes
src/context/PouchDB/PouchDBContext.tsx Outdated Show resolved Hide resolved
src/components/CommentField/CommentField.tsx Outdated Show resolved Hide resolved
src/pouchDB/types.ts Outdated Show resolved Hide resolved
riginoommen
riginoommen requested changes Jul 24, 2021
View reviewed changes
src/pages/HomePage/components/IdeaItem/IdeaItem.tsx Outdated Show resolved Hide resolved
src/pages/IdeaDetailPage/IdeaDetailPage.tsx Outdated Show resolved Hide resolved
src/pages/IdeaDetailPage/IdeaDetailPage.tsx Outdated Show resolved Hide resolved
src/pages/IdeaDetailPage/IdeaDetailPage.tsx Outdated Show resolved Hide resolved
src/utils/binarySearch.ts Show resolved Hide resolved
src/pages/IdeaDetailPage/ideaDetailPage.helper.ts Outdated Show resolved Hide resolved
src/pouchDB/api/comments.ts Show resolved Hide resolved
src/pouchDB/config.tsx Outdated Show resolved Hide resolved
src/pouchDB/config.tsx Outdated Show resolved Hide resolved
src/containers/CommentsContainer/CommentsContainer.tsx Outdated Show resolved Hide resolved
@riginoommen
Copy link
Member

Also please squash the commits

@akhilmhdh akhilmhdh force-pushed the feat/integration-with-couchdb#1159 branch from 48db7f4 to 2381891 Compare July 25, 2021 17:17
@ghanlohar ghanlohar changed the title Feat(1149): Added Pouchdb operations Feat(1149): Added Couchdb operations Jul 25, 2021
@akhilmhdh akhilmhdh force-pushed the feat/integration-with-couchdb#1159 branch from 2381891 to 90e22aa Compare July 26, 2021 06:55
@ghanlohar ghanlohar changed the title Feat(1149): Added Couchdb operations Feat(1149): Added Pouchdb operations Jul 26, 2021
riginoommen
riginoommen requested changes Jul 26, 2021
View reviewed changes
src/layouts/AppLayout/components/AppBanner/AppBanner.tsx Outdated Show resolved Hide resolved
src/pages/HomePage/HomePage.tsx Outdated Show resolved Hide resolved
@akhilmhdh akhilmhdh force-pushed the feat/integration-with-couchdb#1159 branch from 90e22aa to de79e2e Compare July 26, 2021 09:01
riginoommen
riginoommen previously approved these changes Jul 26, 2021
View reviewed changes
deshmukhmayur
deshmukhmayur requested changes Jul 26, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/App.tsx Show resolved Hide resolved
@akhilmhdh akhilmhdh force-pushed the feat/integration-with-couchdb#1159 branch from de79e2e to de7355c Compare July 26, 2021 14:17
deshmukhmayur
deshmukhmayur approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@deshmukhmayur deshmukhmayur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@akhilmhdh
Copy link
Collaborator Author

@riginoommen can you please approve this once more. I think the review got cancelled by the previous change

@riginoommen riginoommen merged commit 14041ab into 1-Platform:main Jul 27, 2021
@akhilmhdh akhilmhdh deleted the feat/integration-with-couchdb#1159 branch July 29, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riginoommen riginoommen riginoommen approved these changes

@deshmukhmayur deshmukhmayur deshmukhmayur approved these changes

@ghanlohar ghanlohar Awaiting requested review from ghanlohar

Assignees

@akhilmhdh akhilmhdh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akhilmhdh @riginoommen @deshmukhmayur