several ts-nocheck resolved
#1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to be reviewed. |
sschmidTU
reviewed
Oct 23, 2021
| from: Note; | ||
| to: Note; | ||
| from: Note | null; | ||
| to: Note | null; |
There was a problem hiding this comment.
Just curious about having null and not undefined. I really wished there was only one thing for that in TS, not two. Though it seemed to me like null is discouraged in Typescript.
At the end of the file changes list, e.g. in stavetie_tests.ts, there was also a comment about maybe changing null to undefined.
|
Can you fix the conflicts please? |
|
@0xfe fixed, ready to review |
Closed
|
Looks good. Thanks Rodrigo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are only two
ts-nocheckpending to be resolved:One in textnote_tests.ts @ronyeh could you include in #1163?
Another one in typeguard_tests.ts which I do not know how to resolve.