feat(cli): export cli actions as node apis #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8dc6640 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
Mar 13, 2024
|
Also needs a changeset |
matthewvolk
force-pushed
the
feat/cli-node-api
branch
from
6360239
to
8dc6640
Compare
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env node | |||
|
|
|||
| import cli from '@gql.tada/cli-utils'; | |||
| cli(); | |||
| (cli as any).default(); | |||
There was a problem hiding this comment.
Are the types erroneously generated now?
There was a problem hiding this comment.
Confirmed types for gql-data-cli.d.ts are the same as they were previous to this change 👍🙂
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #134
Abstract core logic for
generate-schemaandgenerate-outputCLI commands into importable Node.js APIs.Set of changes
The diff is large, but the code is largely the same, mostly just moved around:
generateSchemais unchanged, with the exception of header parsing being pulled out of the function and now headers are passed in as aRecord<string,string>. Additionally,cwdis now an optional parameter (helpful when this methods are called from a directory outside of the directory containing your project'stsconfig.jsonfile, e.g.,npm create some-project).generateTadaTypesis almost entirely unchanged,cwdis now an optional parameter.