Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: connect_params refactoring #281

Merged
merged 3 commits into from
Aug 21, 2024
Merged

chore: connect_params refactoring #281

merged 3 commits into from
Aug 21, 2024

Conversation

kalombos
Copy link
Collaborator

@kalombos kalombos commented Aug 4, 2024

No description provided.

@kalombos kalombos marked this pull request as draft August 4, 2024 06:22
@kalombos
Copy link
Collaborator Author

kalombos commented Aug 14, 2024 •
edited
Loading

How it was in earlier version:

  • You can pass min_connections and max_connections but you cannot pass minsize and maxsize.
  • You can pass connection_timeout which converts to timeout param in aiopg.create_pool and connect_timeout param in aiomysql.create_pool.
  • autocommit param is always true for mysql db.
  • enable_json and enable_hstore is always False for NoExt PostresqlDatabase.
  • enable_json is always True and enable_hstore depends on register_hstore for PostgresqlExtDatabase

@kalombos kalombos marked this pull request as ready for review August 21, 2024 12:58
@kalombos kalombos merged commit 3cf76d4 into master Aug 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kalombos