Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I like your work very much and hope to add Chinese support #27

Closed
Codeapes666 opened this issue Dec 7, 2019 · 12 comments
Closed

I like your work very much and hope to add Chinese support #27

Codeapes666 opened this issue Dec 7, 2019 · 12 comments

Comments

@Codeapes666
Copy link

No description provided.

@zzossig
Copy link
Owner

zzossig commented Dec 7, 2019

@Codeapes666 Hi, I really glad to hear that. I'm also thankful that my Chinese friends find many bugs and tested this repository.

Ok! I really want to support the Chinese language but how?
Do you mean that i18n translation file? Or the Chinese version of the README.MD file?

@fandean
Copy link
Contributor

fandean commented Dec 7, 2019

对的,我也想问,你说的添加中文支持具体指什么? 😄

@fandean
Copy link
Contributor

fandean commented Dec 7, 2019

I think he means support for Chinese search

@zzossig
Copy link
Owner

zzossig commented Dec 7, 2019

I'm using lunr.js for a site searching library. It seems that the Chinese language not supported yet.
There is a pull request for supporting Chinese. But I don't know why the repository owner does not merge the pull request.

I'll think more about how to support Chinese

@fandean
Copy link
Contributor

fandean commented Dec 7, 2019

I've also thought about lunr.js not supporting Chinese search, and I've considered using Google, Baidu, Bing's in-station search, but I don't feel the style is right.

I hope the search features used in this blog below will give you some inspiration.

@zzossig
Copy link
Owner

zzossig commented Dec 7, 2019

@fandean Thank you for spent time with me! I'll add a Chinese search in the future! I'll make a new issue regarding this.

@Codeapes666
Copy link
Author

@zzossig I means support for Chinese search, and also see that lunr does not support Chinese at present.

@Codeapes666
Copy link
Author

@zzossig But I see that this link(https://github.com/nandy007/lunr.js) solves the problem of Chinese search, but I don't understand his meaning at present. I'm a rookie.

@zzossig
Copy link
Owner

zzossig commented Dec 7, 2019

Thanks for the information! I'll investigate more about it. I promise the Chinese search supported in the future

@zzossig zzossig added this to the Search support Chinese, Korean milestone Dec 9, 2019
@zzossig
Copy link
Owner

zzossig commented Dec 10, 2019

@Codeapes666 Update your blog with the latest version of the Zzo theme. I have added support for Chinese. I changed the search library. If you are using an older version, only searching for English is possible.
使用最新版本的Zzo主题更新您的博客。我增加了对中文的支持。
我更改了搜索库。如果您使用的是旧版本,则只能搜索英文

@zzossig zzossig closed this as completed Dec 10, 2019
@Codeapes666
Copy link
Author

It's very nice. Perfect supports Chinese search.

@zzossig
Copy link
Owner

zzossig commented Dec 11, 2019

@Codeapes666 You finally did it. I'm proud of you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants