Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GalleryImage extends \yii\db\ActiveRecord #69

Open
bscheshirwork opened this issue Nov 19, 2018 · 0 comments
Open

GalleryImage extends \yii\db\ActiveRecord #69

bscheshirwork opened this issue Nov 19, 2018 · 0 comments

Comments

@bscheshirwork
Copy link
Contributor

About #7

IMHO The better way is extend from ActiveRecord and refactor all db methods like

$imagesData = $query
->select(['id', 'name', 'description', 'rank'])
->from($this->tableName)
->where(['type' => $this->type, 'ownerId' => $this->getGalleryId()])
->orderBy(['rank' => 'asc'])
->all();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant