Delete directory after delete all images #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxbodya
reviewed
Nov 19, 2018
| @@ -223,6 +222,27 @@ public function getFilePath($imageId, $version = 'original') | |||
| return $this->directory . '/' . $this->getFileName($imageId, $version); | |||
| } | |||
|
|
|||
| public function getDirectoryPath() | |||
There was a problem hiding this comment.
IMHO This functional can be use outside widget for build the path to galery folder of model
There was a problem hiding this comment.
Also we can redefine it in children
| @@ -314,6 +348,9 @@ function ($image) use (&$removed) { | |||
| } | |||
| ); | |||
| } | |||
| if (is_null($this->_images)) { | |||
| $this->removeDirectory($this->getDirectoryPath()); | |||
| } | |||
There was a problem hiding this comment.
this is not correct - is_null($this->_images) means only that getImages() method was not called yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested of #65
Fix #67
NOTE: This new behavior with remove folder MUST have a line on changelog.