Added translator for The Saturday Paper #3099
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added article section detection. Added edition detection. Added snapshot of article. Adjusted test cases.
Comment on lines
+83
to
+89
| item.publicationTitle = "The Saturday Paper"; | ||
| item.title = attr(doc, 'meta[name="dcterms.title"]', 'content'); | ||
| item.date = ZU.strToISO(attr(doc, 'meta[name="dcterms.date"]', 'content')); | ||
| item.abstractNote = attr(doc, 'meta[name="dcterms.description"]', 'content'); | ||
| item.creators.push(ZU.cleanAuthor(attr(doc, 'meta[name="dcterms.creator"]', 'content'), "author")); | ||
| item.language = "en-AU"; | ||
| item.url = url; |
There was a problem hiding this comment.
Here, I think it suffices to make use of the 'Embedded Metadata' translator (such as by using the template code from Scaffold -> Tools menu -> Templates) for the majority of these fields. The EM translator will take care of these <meta> fields, and any improvements to EM translator will be automatically picked up by the translators that use it.
| let editionRaw = doc.querySelector('p.issue-nav__current').textContent; | ||
| var em = editionRaw.match(/.*No\.\s(\d+)/); | ||
| if (em) { | ||
| item.edition = em[1]; |
There was a problem hiding this comment.
Are we sure "edition" is the appropriate field? I think this refers to editions of a book, or in the context of newspapers, the different "prints" or versions of a particular day's issue, due to intra-day updates (edits).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a translator for Australian newspaper The Saturday Paper.