News Corp Australia: Scraping updates for more recent website editions #3071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update the selectors for breadcrumb navigation (for section title), and stop using lastChild which can be a text node. - Use page URL directly as the URL field, because URL in JSON data may point to a different domain. - Prefer title scraped from page body, because the one from JSON data may fail to match the former, possibly due to social media SEO. - More robust determination of authors, accounting for different data formats across different sites. See also: https://forums.zotero.org/discussion/105950/attempt-to-save-using-embedded-metadata
AbeJellinek
requested changes
Jul 13, 2023
adam3smith
pushed a commit
to adam3smith/translators
that referenced
this pull request
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also:
https://forums.zotero.org/discussion/105950/attempt-to-save-using-embedded-metadata