Skip to content

Commit

Permalink
Fix CI check breakage due to chromedriver changes (#3101)
Browse files Browse the repository at this point in the history
As of version 115, ChromeDriver uses different package distribution
method (more details at https://googlechromelabs.github.io/chrome-for-testing/),
and currently used version 95.0.0 is not able to handle that,
so all PR checks fail with the following message:

    Your Chrome version is 115.0.5790.110
    Finding Chromedriver version.
    ChromeDriver installation failed Error: Request failed with status code 404
        at createError (/home/runner/work/translators/translators/node_modules/axios/lib/core/createError.js:16:15)
        at settle (/home/runner/work/translators/translators/node_modules/axios/lib/core/settle.js:17:12)
        at IncomingMessage.handleStreamEnd (/home/runner/work/translators/translators/node_modules/axios/lib/adapters/http.js:269:11)
        at IncomingMessage.emit (node:events:539:35)
        at endReadableNT (node:internal/streams/readable:1345:12)
        at processTicksAndRejections (node:internal/process/task_queues:83:21) {
      config: {
        url: 'https://chromedriver.storage.googleapis.com/LATEST_RELEASE_115.0.5790',
        method: 'get',
        headers: {
          Accept: 'application/json, text/plain, */*',
          'User-Agent': 'npm/8.11.0 node/v17.9.1 linux x64 workspaces/false ci/github-actions'
        },
    <...and so on...>

Just updating the chromedriver package is enough to fix, so here it is.

Tested on my fork of the repo, see e.g.,
https://github.com/alex-ter/translators/actions/runs/5777601767/job/15657962595?pr=1
  • Loading branch information
alex-ter authored Aug 6, 2023
1 parent 3f75317 commit 1590d01
Show file tree
Hide file tree
Showing 2 changed files with 126 additions and 429 deletions.
Loading

0 comments on commit 1590d01

Please sign in to comment.