Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Op traits #194

Merged
merged 14 commits into from
Apr 20, 2023
Merged

refactor: Op traits #194

merged 14 commits into from
Apr 20, 2023

Conversation

alexander-camuto
Copy link
Collaborator

@alexander-camuto alexander-camuto commented Apr 18, 2023

Op notation has started to become overloaded and we need to split ops into multiple files. To help with this we create a generic Op trait that is common to all implemented operations.

This PR reconfigures the circuit module to use this trait.

should also:

  • deprecate theOpKind enum in the graph module
  • move towards using traits in function calls.

Bonuses:

  • starts to implement instance_norm
  • fix: thanks to @Mickanos for flagging that the neg doesn't constraint with NEG selector
  • creates a dummy layout pass for more accurately estimating the num of rows needed (rather than having to calculate those values by hand)
  • reduces model configuration to a single config.

@alexander-camuto alexander-camuto marked this pull request as ready for review April 20, 2023 07:15
@alexander-camuto alexander-camuto merged commit 0796594 into main Apr 20, 2023
@alexander-camuto alexander-camuto deleted the ac/instance-norm branch April 20, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant