Spike/real device #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add wasmer dependency and basic test
- Sketch function for new API - Focusing on witness generation first - Add basic test
Need more fine-grained build control for dylib, can improve this later
|
Minimal diff for wasmer only #8 I'll separate out the dylib stuff at some point as I think we want it |
|
Rust dylib and wasmer stuff integrated. The PR still has some Xcode/script updates that could be useful, so leaving it open for now. |
Closed
|
Out of date with recent work |
vivianjeng
added a commit
that referenced
this pull request
Jul 2, 2024
* refactor: remove wasm, add native proof generation (#179) * chore: rename rsa circuit from main to main_rsa remove wasmer dep remove static proof generation logic, in memory zkey, etc add rust_witness chore: switch to git copy of rust-witness fix: rsa circuit path fix: mutability fix: re-enable example fix: move witness fn into scope refactor: register list of proofs fix: build anonaadhaar wasm to fix ci refactor: remove wasm path fix: zkey pathing chore: remove wasmer ref chore: switch to wasm delete copy of circom-compat * chore: remove mutability and ignore * chore: comment anonaadhaar build chore: switch to zkmopro circom-compat fork chore: update cargo lock * fix: compile error in build script * fix: put anonaadhaar tests behind feature flag * chore: remove wasmer deps * refactor: pass zkey path through ffi bridge * chore: rebase, revert name changes * chore: comments * chore: fix halo2 build * chore: conditionals............... * refactor: remove mopro-core, transfer logic to mopro-ffi refactor: separate circom/halo2 functions in udl * chore: remove unused files chore(ci): split circom and halo2 tests * chore(ci): test on sync * chore(ci): fix * fix: properly throw errors in e2e test, fix swift zkey path * chore(ci): only build halo2 feature in ci * wip: app_config api * refactor: remove ark_zkey * fix: uniffi test bindings, fix warnings, cleanup dead code * cleanup: remove web-prover, templates, scripts, mopro-cli * chore: remove redundant compiler flags * feat: custom circuit config * refactor: move uniffi platform tests to separate package * chore: update ci tests, move WtnsFn to mopro_ffi * fix: halo2 depend num-bigint * refactor: simplify circuit_data implementation * feat: ios build support * fix: installs archs during ios build * chore: disable default feature * chore: add comment fix: don't export circom and halo2 modules * chore: update readmes * fix: platform parsing * chore: add getting started section * fix: move rust-witness dep * chore: remove mopro-web * chore: remove unused deps * chore: remove deps * chore: fix halo2 build * chore: update rust-witness, remove paste * chore: remove images * refactor: pull ios logic into own file, build multiple architectures * fix: debug/release selection * feat: EXTRA_ARCHS compile option * fix: build universal binary * fix: make tmpdir in local build dir * fix: create build dir if needed * chore: add kotlin bindings * refactor: change circuit_data -> zkey_witness_map, pass full zkey filename * readme tutorial (#5) * wip: readme tutorial * fix: use the name zkey_witness_map function name * chore: update package lock * chore: re-add mopro-web * refactor: mopro-web -> docs * chore: update docs edit url * feat: add exporting android bindings (#1) * feat: add exporting android bindings * chore: install cargo-ndk * chore: apply suggestions * chore: apply suggestions from chatGPT, fix cargo ndk build * chore: update readme * refactor: output ios bindings to MoproiOSBindings, closes #7 * fix(ci): prevent duplicate jobs in pr * Add apps (#10) * feat: add ios app to test-e2e * feat: add android build * chore: update ci * chore: commit gradle wrapper * versioned docs (#11) * fix(docs): header scroll bug * feat: versioned docs * refactor(docs): update docs for reworked repo * chore: update repo urls * chore(docs): update project list --------- Co-authored-by: Ya-wen, Jeng <vivi432@yahoo.com.tw>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After more than 30h and over more than a week, with lots of attempts and many different changes I think I got real device to work.
See #1
I'll factor out more minimal diffs from this to make it more usable. The key diff seems to be using a wasmer memory patch.
This PR is also sketching out dylib use, which might not be 100% needed, but is something we might want down the line.
Screenshot from real device