NOVA Scotia folding scheme test done #227

[csiejimmyliu]

• Nova Scotia folding test in morpo ffi
• Using toy r1cs example of Fibonacci sequence

[vivianjeng]

It looks good! Thank you for your contribution
there are several points that can be changed

1. rename the circuit (toy -> e.g.adder or fibonacci)
2. remove temporary files jna-5.13.0.jar, toy_js/ ( we just need the r1cs and wasm
3. try to run test with cargo test --features nova_scotia and include the CI script like
   

   mopro/.github/workflows/build-and-test.yml

   Lines 35 to 36 in b625093

   	- name: Run ffi halo2 tests
   	run: cd mopro-ffi && cargo test --features halo2 --no-default-features

[vivianjeng]

and please use cargo fmt --all to format the code

[vivianjeng]

Thank you for fixing the errors
Can you fix the feature's name to nova-scotia
Thank we can merge this PR 🙏🏻

[vivianjeng]

can we align the usage of - and _
I prefer the feature flag be nova-scotia
e.g. --features nova-scotia
(but in rust code some place needs to be nova_scotia then just keep them nova_scotia)

[vivianjeng]

this can be changed to

nova-scotia = [
    "dep:nova-scotia",

to activate the dependency with the same name

[vivianjeng]

we should remove this (for now)
since we don't activate the nova-scotia feature
(and it needs to work without these dependencies)

but once you update the type for udl (serialization)
it should be solved easily
it can be done in another PR