Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the unicode-width dep pinned to version 0.11.1? #423

Open
discosultan opened this issue Aug 12, 2024 · 6 comments
Open

Why is the unicode-width dep pinned to version 0.11.1? #423

discosultan opened this issue Aug 12, 2024 · 6 comments
Labels
question Further information is requested

Comments

@discosultan
Copy link

unicode-width = "=0.1.11"

@russellbanks
Copy link

This is what I could find: #415 (comment).

However this means that you can't use tabled if you have dependencies that also use unicode-width, like ratatui:

error: failed to select a version for `unicode-width`.                                                                                                                                                                                                                                                             
    ... required by package `papergrid v0.12.0`
    ... which satisfies dependency `papergrid = "^0.12"` of package `tabled v0.16.0`
    ... which satisfies dependency `tabled = "^0.16.0"`
versions that meet the requirements `=0.1.11` are: 0.1.11

all possible versions conflict with previously selected packages.

  previously selected package `unicode-width v0.1.13`
    ... which satisfies dependency `unicode-width = "^0.1.13"` of package `ratatui v0.28.0`
    ... which satisfies dependency `ratatui = "^0.28.0"`

@discosultan
Copy link
Author

Ran into the same issue in combination with ratatui :)

@zhiburt
Copy link
Owner

zhiburt commented Aug 15, 2024

Good question

Ahhhh I was not expecting such outcomes

I guess you better stick with v0.14 then till it's resolved?

The thought about this bound was that they had changed the logic of calculations.
So important assumption that width(char) == width(string(char)) no longer true (maybe it was a wrong assumption to begin with).
Because of this some emojie and complex UTF8 symbols was incorrectly rendered.

So I decided to make this bound.
But maybe it shall be investigated (the logic changed accordingly) to be removed.

@zhiburt zhiburt added the question Further information is requested label Aug 15, 2024
@zhiburt
Copy link
Owner

zhiburt commented Aug 23, 2024

@discosultan @russellbanks

I had to mention that you can do it by changes in Cargo.toml

tabled = "=0.14" # or whatever version you were bound to

Sorry for ping; just wanna make sure it's resolved on your end.

Have a great weekend.

@discosultan
Copy link
Author

Thanks for the follow-up. That's the workaround I went with.

Enjoy the weekend.

@joshtriplett
Copy link

I ran into this as well, and it's likewise blocking me from upgrading tabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants