Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy and tests fail due to simple problems #414

Closed
strange-dv opened this issue Jul 11, 2024 · 2 comments · Fixed by #415
Closed

clippy and tests fail due to simple problems #414

strange-dv opened this issue Jul 11, 2024 · 2 comments · Fixed by #415
Labels
question Further information is requested

Comments

@strange-dv
Copy link
Contributor

strange-dv commented Jul 11, 2024 •
edited

This issue is more of a way to understand the status of this project, as I love it and want to contribute by fixing some bugs. However, I found out that cargo test and clippy and thus CI don't work due to simple code errors.

Why is everyone ignoring them? Is it intentional or is it okay if someone fixes these errors?
@zhiburt
Copy link
Owner

zhiburt commented Jul 11, 2024 •
edited

Hi @strange-dv

Yes;
The clippy and tests fails came up by themselfs a few month ago, to be honest I am not sure even why.
Seemingly updated clippy; but why test got to fail that's very very interesting, I haven't checked to be brutally honest (I did but way back then).

I am not ignoring it.
I am aware of it.

I just have some OLD (VERY OLD) (a few months ....) patch I must have completed......
very interesting patch (at least 3 important ones)
But I ...... just .... can't get it done........sooooon hopefully....

So if you @strange-dv want you can peek it up, it'd be great.
You can ping me if you'll got some issues.

PS: Overall I can do it too; as I said; I just haven't prioritized it

@zhiburt zhiburt added the question Further information is requested label Jul 11, 2024
@strange-dv
Copy link
Contributor Author

thanks for the answer! I'll try to pick it up!

@strange-dv strange-dv mentioned this issue Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix clippy and tests fail due to simple problems strange-dv/tabled
2 participants
@zhiburt @strange-dv