Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron 8.1.1 can not build with zeromq #396

Closed
bindy opened this issue Apr 21, 2020 · 6 comments · Fixed by #444
Closed

electron 8.1.1 can not build with zeromq #396

bindy opened this issue Apr 21, 2020 · 6 comments · Fixed by #444

Comments

@bindy
Copy link

bindy commented Apr 21, 2020

http 404 https://github.com/zeromq/zeromq.js/releases/download/v5.2.0/zeromq-v5.2.0-electron-v76-win32-x64.tar.gz

@bindy bindy added the bug label Apr 21, 2020
@hangon1234
Copy link

Having exactly same issue. Problem seems like the newer version of electron does not support old zeromq version. I tried to change version ^6.x.x-beta. But it seems build script is only for linux environment, which will cause build to crash.
When I try to build zeromq, I get message "sh not recognized...." so the build script only written in .sh extension and doesn't have .bat version.
I am very new to write build script.
Can anyone look into it and make PR? I don't want to use old version of electron

@hangon1234
Copy link

what i did in last few hours
npm install zerorpc
(electron-root)/node_modules/.bin/electron-rebuild
produces error message : syntax error, bla bla...
I guess because old version of zeromq or python script makes problem. (not sure :( )
than i modify (electroy-root)/node-modules/zerorpc/package.json and zeromq ^6.x.x than save it
and then cd to (electron-root)/node-modules/zerorpc than run "npm install" without any problem.
now go to (electron-root) again and try to build again
./(electron-root)/node_modules/electron-build
and then after while I get error message: sh is not recognized~....
not sure if it builds correctly in linux/mac environment.
any suggestion?

@hangon1234
Copy link

solved the problem. don't need wsl (windows subsystem linux)
you can use git bash for windows.
I guess it comes with Git for Windows by default.
then go to your project root, simply run electron-rebuild again.
You might get error message like cmake doesn't exist, just search google and install it.
After that I can finally run npm start!
Will test if it really can import zerorpc and connect to local zerorpc server.
Just want anybody find it helpful. Git bash solved the problem. Nice!

@hangon1234
Copy link

before run electron-rebuild , make sure you change zerorpc's package.json and set the version of zeromq to 6.x.x and save it.
than run "npm install" in the zerorpc directory
than go back to project root and try to build.

@mikelyndersOKCC
Copy link

mikelyndersOKCC commented Jul 21, 2020

@hangon1234 I am running into the following issue on windows 10. I followed you instructions, ran electron-rebuild in git-bash and it seems I have an issue with cmake. I installed Visual Studio 2019 and restarted my computer. Did you have any issue here?

build_libzmq
 Downloading libzmq source...
 Building libzmq...
 CMake Error at CMakeLists.txt:2 (project):
   Generator

     Visual Studio 15 2017 Win64

   could not find any instance of Visual Studio.

Edit: I uninstalled Visual Studio 2019 and replaced with 2017. Make sure to include the C++ tools for desktop development. electron-rebuild succeeded but still getting error Error: No native build was found for platform=browser arch=javascript runtime=electron abi=undefined uv= libc=glibc node=undefined webpack=true in console

@hangon1234
Copy link

hangon1234 commented Jul 25, 2020

@hangon1234 I am running into the following issue on windows 10. I followed you instructions, ran electron-rebuild in git-bash and it seems I have an issue with cmake. I installed Visual Studio 2019 and restarted my computer. Did you have any issue here?

build_libzmq
 Downloading libzmq source...
 Building libzmq...
 CMake Error at CMakeLists.txt:2 (project):
   Generator

     Visual Studio 15 2017 Win64

   could not find any instance of Visual Studio.

Edit: I uninstalled Visual Studio 2019 and replaced with 2017. Make sure to include the C++ tools for desktop development. electron-rebuild succeeded but still getting error Error: No native build was found for platform=browser arch=javascript runtime=electron abi=undefined uv= libc=glibc node=undefined webpack=true in console

@mikelyndersOKCC Hi, I finally decided not use zeromq.
Instead, use python-nodejs libary which uses simple stdout/stdin
Python-shell which I used (https://www.npmjs.com/package/python-shell)
Hope this can help you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants