You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reporting here the discussion with the aim to evaluate the best option to improve them.
There still is a problem involving socket_ref and comparison operators, that I quickly workaround (not committed). I'll investigate further and in case I will open an issue to understand the best way to fix it.
Ok, I've just narrowed down the problem. For socket_ref a set of comparison operators is defined (starting from here), moreover it is possible to implicitly cast a socket_t to a socket_ref thanks to
so, it is possible to use these comparison operators with both types.
But with Catch a problem arose, because CHECK(sr == s) passes by const& the operands and the cast operator for const socket_t is not available.
Unfortunately, I'm not used to the API of the library, so I would have to dig a bit to understand what's better to do (e.g. enabling the socket_ref operator by adding const). I can commit this proposal, just to see if other problems will come up in CI.
I don't know if you want me to open an issue about this, or if we want to keep it here and solve it directly.
Reporting here the discussion with the aim to evaluate the best option to improve them.
Ok, I've just narrowed down the problem. For
socket_ref
a set of comparison operators is defined (starting from here), moreover it is possible to implicitly cast asocket_t
to asocket_ref
thanks tocppzmq/zmq.hpp
Line 2186 in 18db456
so, it is possible to use these comparison operators with both types.
But with Catch a problem arose, because
CHECK(sr == s)
passes byconst&
the operands and the cast operator forconst socket_t
is not available.Unfortunately, I'm not used to the API of the library, so I would have to dig a bit to understand what's better to do (e.g. enabling the
socket_ref
operator by addingconst
). I can commit this proposal, just to see if other problems will come up in CI.I don't know if you want me to open an issue about this, or if we want to keep it here and solve it directly.
Originally posted by @albestro in #466 (comment)
The text was updated successfully, but these errors were encountered: