-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prodigy annotator #2655
Prodigy annotator #2655
Conversation
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 38.1%, saving 36.22 KB.
256 images did not require optimisation. Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions. |
@coderabbitai review |
… into feature/prodigy-annotator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
Out of diff range and nitpick comments (3)
scripts/install-zenml-dev.sh (2)
Line range hint
51-51
: Consider enclosing$ignore_integrations_args
in double quotes to prevent globbing and word splitting.- zenml integration export-requirements --output-file integration-requirements.txt $ignore_integrations_args + zenml integration export-requirements --output-file integration-requirements.txt "$ignore_integrations_args"
Line range hint
54-54
: For efficiency, consider using braces for multiple commands redirecting to the same file.- echo "" >> integration-requirements.txt - echo "pyyaml>=6.0.1" >> integration-requirements.txt - echo "pyopenssl" >> integration-requirements.txt - echo "-e .[server,templates,terraform,secrets-aws,secrets-gcp,secrets-azure,secrets-hashicorp,s3fs,gcsfs,adlfs,dev,mlstacks]" >> integration-requirements.txt + { + echo "" + echo "pyyaml>=6.0.1" + echo "pyopenssl" + echo "-e .[server,templates,terraform,secrets-aws,secrets-gcp,secrets-azure,secrets-hashicorp,s3fs,gcsfs,adlfs,dev,mlstacks]" + } >> integration-requirements.txtsrc/zenml/integrations/prodigy/annotators/prodigy_annotator.py (1)
67-76
: The methodget_url_for_dataset
does not use thedataset_name
parameter. Consider removing it if it's truly unnecessary, or document why it's kept.
docs/book/stacks-and-components/component-guide/annotators/prodigy.md
Outdated
Show resolved
Hide resolved
…digy.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request adds the Prodigy Annotator integration to ZenML. Prodigy is a powerful annotation tool that allows for efficient data labeling. With this integration, users can now connect ZenML with Prodigy and leverage its annotation capabilities in their ML pipelines.
Note, there are no tests included in this PR since
prodigy
the package is only installable via a custom wheel they ship when you buy a license (and thus isn't possible to install and use in our CI). I also made one small change to the base annotator interface to accommodate this new annotator.I've developed and tested this on my machine (since I have a license).
Summary by CodeRabbit
New Features
BaseAnnotator
to accept additional keyword arguments, improving flexibility.Documentation
Chores
Refactor
Bug Fixes