-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZenML Server activation and user on-boarding #2630
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
fb03bbc
to
fafab4b
Compare
Quickstart template updates in |
E2E template updates in |
…ml-io/zenml into feature/cloudk-484-server-onboarding
NLP template updates in |
…raform deployments
…ml-io/zenml into feature/cloudk-484-server-onboarding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, that Server Settings are in the DB now 👍🏼
Left a few minor changes/questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, if CI pass 👍🏼
Describe changes
This PR changes the way that ZenML server are being provisioned immediately after deployment to exclude the automated creation of the so called
default
user. A new server activation flow is introduced that works as follows:inactive
state, marked by a False value for the newactive
field in the server info object. When the dashboard is opened in this state, the user will be walked through the server activation flow, which consists of the following:/api/v1/activate
endpoint that 1. activates the server (togglesactive
to True) 2. creates an initial admin user account with the given name/password 3. automatically logs in the user using the new accountThe server activation feature only works with the new OSS dashboard. If users want to explicitly configure new ZenML server deployments to use the old dashboard, the legacy behavior of automatically activating the server and automatically creating the default admin user account will be automatically enabled (FYI @avishniakov ).
The legacy behavior can also be enabled by setting the
ZENML_SERVER_AUTO_CREATE_DEFAULT_USER
environment variable toTrue
for those who need a ready-to-go ZenML server that is automatically pre-activated on deployment.The following server deployments are unaffected by this and will continue to have a
default
user account created automatically on deployment:zenml up
Side changes
This includes some changes required to support server settings and user on-boarding:
identity
table has been renamed toserver_settings
and now contains new server-wide settings attributes in addition to the previousid
deployment identifier:active
attributeuser_metadata
attribute that can be used by the dashboard to store additional informationBackwards compatibility
Existing server deployments are already active and have at least one admin account already configured.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes