Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo in center field in live football games #458

Closed
wants to merge 38 commits into from

Conversation

mamamia5x
Copy link
Contributor

I was tinkering around and came up with a way to show the logo. Here is how they currently look.
image
image

I'm not that good with TS, so it took me a bit to figure things out.
Notes:

  • The all star game isn't implemented in this new play by play, so the logo isn't implemented in there yet.
  • The home team logo is shown in the championship game, even if in a neutral spot.
  • If a team does not have a logo, it will not display the logo.

Please let me know if you have any questions or if there is anything else I can do to this.

@dumbmatter
Copy link
Member

Very cool! I thought about doing this myself but I decided it might look too busy. I'll leave this PR open in case I reconsider. For now, I still have a ways to go on the basic functionality of the new feature.

@mamamia5x
Copy link
Contributor Author

It's looking good so far.
Just a quick idea, maybe there could be a way to change grass color. Whether it's from the actual team data (like having jersey colors + grass colors), or just different shades of green picked by a random number generator.

@mamamia5x
Copy link
Contributor Author

Just updated the code to fit the current build, just have to resolve some conflicts. I changed the image size to fit around 10 yards in the center.
image

@mamamia5x
Copy link
Contributor Author

#459 is the updated branch

@mamamia5x mamamia5x closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants