Add support for custom hot reload config #823

timneutkens · 2017-01-18T23:28:25Z

arunoda · 2017-01-19T00:32:04Z

Shall we document this in the README.

timneutkens · 2017-01-19T05:27:01Z

@arunoda definitely, wanted you to check it first :)

nkzawa · 2017-01-19T05:44:29Z

server/hot-reloader.js

+
+    if (this.config.hotReloader) {
+      console.log('> Using "hotReloader" config function defined in next.config.js.')
+      hotReloaderConfig = this.config.hotReloader(hotReloaderConfig)


This should be called webpackDevMiddleware instead of hotReloader ?

Updated 🙌

nkzawa · 2017-01-19T05:49:39Z

I'm not sure if this is required, since ideally, typescript files also should be transpiled via webpack (maybe by https://github.com/TypeStrong/ts-loader). In this case you don't have to change the ignored option.

nkzawa · 2017-01-19T06:21:03Z

I have no good idea about #757 though :|

arunoda · 2017-01-19T06:45:39Z

@nkzawa That's a good case of having this API. But not sure we should do it now or wait for 2.0?

timneutkens · 2017-01-19T07:23:48Z

@arunoda was thinking about this myself. I guess 2.1 since it's a new feature.

timneutkens · 2017-01-19T07:34:40Z

Added to readme. Also added the poweredByHeader option, since it was undocumented.

nkzawa · 2017-01-19T10:26:34Z

server/hot-reloader.js

@@ -130,7 +132,7 @@ export default class HotReloader {
      }
    } : {}

-    this.webpackDevMiddleware = webpackDevMiddleware(compiler, {
+    let hotReloaderConfig = {


let's rename this too

nkzawa · 2017-01-19T10:26:52Z

server/hot-reloader.js

+    }
+
+    if (this.config.webpackDevMiddleware) {
+      console.log('> Using "hotReloader" config function defined in next.config.js.')


jagreehal · 2017-01-19T13:32:53Z

@timneutkens this looks great. Thank you.

@nkzawa in my (limited) experience of using TypeScript loaders (both ts-loader and awesome-typescript-loader) is they can introduce additional problems and confusion especially when babel plugins are also used.

digitalkaoz · 2017-04-17T09:01:54Z

@nkzawa what is the state of this PR? would love to see this merged, b.c. using next with external sheets is a bit painful :/

dillondotzip · 2017-05-06T18:41:40Z

@nkzawa This couldn't come any sooner... Thanks for this @timneutkens

timneutkens · 2017-05-10T08:20:05Z

Created a new PR, cause merging master with this branch was not possible.

BafS · 2017-10-15T08:40:09Z

Any news ? Thanks in advance !

bytewiz · 2017-11-08T09:39:35Z

We need this feature, resolved 👍

lock · 2018-05-10T17:47:24Z

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

ijjk · 2019-10-05T09:57:02Z

Stats from current PR

Default Server Mode

General

	zeit/next.js canary	zeit/next.js canary	Change
buildDuration	16.1s	17.4s	⚠️ +1.4s
nodeModulesSize	48.3 MB	48.3 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	zeit/next.js canary	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..6604acae7.js	43.2 kB	43.2 kB	✓
de003c3a9d30..cae7.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	zeit/next.js canary	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..42.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	zeit/next.js canary	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	zeit/next.js canary	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	zeit/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	zeit/next.js canary	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	946 B	946 B	✓
link.html	3.66 kB	3.66 kB	✓
link.html gzip	954 B	954 B	✓
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	942 B	942 B	✓
Overall change	10.9 kB	10.9 kB	✓

Serverless Mode

General

	zeit/next.js canary	zeit/next.js canary	Change
buildDuration	17.1s	18.2s	⚠️ +1.2s
nodeModulesSize	48.3 MB	48.3 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	zeit/next.js canary	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..6604acae7.js	43.2 kB	43.2 kB	✓
de003c3a9d30..cae7.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	zeit/next.js canary	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..42.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	zeit/next.js canary	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	zeit/next.js canary	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	zeit/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles

	zeit/next.js canary	zeit/next.js canary	Change
_error.js	253 kB	253 kB	✓
_error.js gzip	67.9 kB	67.9 kB	✓
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	979 B	979 B	✓
index.js	254 kB	254 kB	✓
index.js gzip	68.2 kB	68.2 kB	✓
link.js	261 kB	261 kB	✓
link.js gzip	70.3 kB	70.3 kB	✓
routerDirect.js	255 kB	255 kB	✓
routerDirect.js gzip	68.3 kB	68.3 kB	✓
withRouter.js	254 kB	254 kB	✓
withRouter.js gzip	68.4 kB	68.4 kB	✓
Overall change	1.28 MB	1.28 MB	✓

Commit: 3f1e19e

Add support for custom hot reload config

0435238

This was referenced Jan 18, 2017

Add typescript example #96

Closed

Hot reload on virtualbox with windows folder mount #757

Closed

nkzawa reviewed Jan 19, 2017

View reviewed changes

nkzawa added this to the 2.1 milestone Jan 19, 2017

Rename variable

79a5763

Add docs for all next.config.js options

6719157

nkzawa reviewed Jan 19, 2017

View reviewed changes

timweprovide added 2 commits January 19, 2017 13:21

Rename variables

56844eb

Rename vars

df0155f

timneutkens added the Status: Ready label Mar 16, 2017

damianstasik mentioned this pull request Apr 24, 2017

Hot reloader polling? #1787

Closed

dillondotzip mentioned this pull request May 6, 2017

How to enable polling inside webpack watch? #1899

Closed

timneutkens mentioned this pull request May 10, 2017

Add custom webpack dev middleware config #1931

Merged

timneutkens closed this May 10, 2017

timneutkens deleted the custom-hotreload-config branch May 10, 2017 08:19

thundermiracle mentioned this pull request Jun 7, 2017

How to Enable hmr on virtualbox #2179

Closed

JoseMartinC mentioned this pull request Jul 7, 2017

SASS hot-reloading on with-external-scoped-css example #2495

Closed

1 task

lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for custom hot reload config #823

Add support for custom hot reload config #823

timneutkens commented Jan 18, 2017

arunoda commented Jan 19, 2017 •

edited

Loading

timneutkens commented Jan 19, 2017

nkzawa Jan 19, 2017

timneutkens Jan 19, 2017

nkzawa commented Jan 19, 2017

nkzawa commented Jan 19, 2017

arunoda commented Jan 19, 2017

timneutkens commented Jan 19, 2017

timneutkens commented Jan 19, 2017

nkzawa Jan 19, 2017

timneutkens Jan 19, 2017

nkzawa Jan 19, 2017

timneutkens Jan 19, 2017

jagreehal commented Jan 19, 2017

digitalkaoz commented Apr 17, 2017

dillondotzip commented May 6, 2017

timneutkens commented May 10, 2017 •

edited

Loading

BafS commented Oct 15, 2017

bytewiz commented Nov 8, 2017

lock bot commented May 10, 2018

ijjk commented Oct 5, 2019

Add support for custom hot reload config #823

Add support for custom hot reload config #823

Conversation

timneutkens commented Jan 18, 2017

arunoda commented Jan 19, 2017 • edited Loading

timneutkens commented Jan 19, 2017

nkzawa Jan 19, 2017

Choose a reason for hiding this comment

timneutkens Jan 19, 2017

Choose a reason for hiding this comment

nkzawa commented Jan 19, 2017

nkzawa commented Jan 19, 2017

arunoda commented Jan 19, 2017

timneutkens commented Jan 19, 2017

timneutkens commented Jan 19, 2017

nkzawa Jan 19, 2017

Choose a reason for hiding this comment

timneutkens Jan 19, 2017

Choose a reason for hiding this comment

nkzawa Jan 19, 2017

Choose a reason for hiding this comment

timneutkens Jan 19, 2017

Choose a reason for hiding this comment

jagreehal commented Jan 19, 2017

digitalkaoz commented Apr 17, 2017

dillondotzip commented May 6, 2017

timneutkens commented May 10, 2017 • edited Loading

BafS commented Oct 15, 2017

bytewiz commented Nov 8, 2017

lock bot commented May 10, 2018

ijjk commented Oct 5, 2019

Stats from current PR

arunoda commented Jan 19, 2017 •

edited

Loading

timneutkens commented May 10, 2017 •

edited

Loading